feat: theme toggle#932
Conversation
|
Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @Palakchoithani!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @PalakchoithaniBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
This PR adds theme support and improves accessibility across the export flow. What changed:
Validation:
Thanks for reviewing. |
|
Hey @Palakchoithani! Thank you for your work on this, but I need to let you know that a theme toggle is already fully implemented in Additionally, this PR:
Since the core feature (theme toggle) is already shipped, I'm going to close this PR. If you'd like to contribute, check the open issues for something that hasn't been done yet — we'd love to have you! Thanks again for your time! |
Description
Added theme-related UI support and persistence behavior, improved export readability in dark mode and high-contrast mode, fixed the onboarding tour crash, and cleaned up lint/typecheck issues in the branch.
Related Issue
Closes #928
Type of Contribution
Participant Info
Screen Recording
596754167-e9c370fa-7463-4f8c-b949-6ed6cc0090ef.mov
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in